decentraland / comms-gatekeeper / 34352827071

86%

push

github

fix: mint the same preview room on both scene-adapter endpoints (#294)

/get-scene-adapter has minted getSceneRoomName(realmName, sceneId) for preview
realms since 2.25.0 (#249), so preview clients share a room with cast2 streamers
and presentation bots. /get-server-scene-adapter kept the older
`preview-<sceneId>` name, leaving an SDK preview with its authoritative server
in one LiveKit room and its clients in another — the scene loads, nothing syncs,
and neither side logs an error.

Drop the preview branch rather than copy the name: a preview realm is never
`.eth`, so it falls through to the scene-room name the client already uses.
sceneId becomes required on every realm, mirroring #257 on the client side.

Preview rooms now match SCENE_ROOM_PREFIX, so the webhook metadata refresh would
resolve a place from a `b64-` preview id on every join and leave — a lookup that
can only fail, and whose failure path releases the cooldown. Skip preview realms
there by realm name, as the webhook event handlers already do.

1154 of 1463 branches covered (78.88%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 2 files covered. (100.0%)

3146 of 3532 relevant lines covered (89.07%)

79.33 hits per line