coreui / coreui-pro / 34878529876

96%

main: 94%

push

github

refactor(Combobox, ListBox, MultiSelect, Transfer)!: one selectedLabel, which can be a function (#1295)

Four components rendered the same sentence under three option names and two
shapes: Combobox substituted `{count}` into `selectedText`, ListBox and
Transfer appended `selectedCounterText` after `count/total`, MultiSelect
appended `selectionTypeCounterText` after the count.

Appending cannot be translated. The translator receives only the tail of the
sentence, so the number cannot move and the noun cannot be inflected — Polish
needs "2 zaznaczone", "5 zaznaczonych" and "1 zaznaczony" out of one option,
and a language that puts the number last cannot be served at all.

All four now take `selectedLabel`, typed `(string|function)`:

  selectedLabel: (count, total) => `${count}/${total} selected`   ListBox, Transfer
  selectedLabel: count => `${count} selected`                     Combobox
  selectedLabel: count => `${count} item(s) selected`             MultiSelect

The string form stays because a function cannot be written into
`data-coreui-selected-label`; `{count}` and `{total}` are replaced in it, so a
markup-only page keeps a translatable counter. `resolveCountLabel` in
`util/index.ts` holds the one branch, since four components need it.

Positional arguments, not an options object, because the two function options
the library already ships are positional and public since v5:
`Rating.ariaLabel(value, itemCount)` and `OTPInput.ariaLabel(index, total)`.
`total` is passed everywhere, including the two components whose default text
ignores it, so one function serves all four.

`coreui.js` goes to 138.5 KB. Measured in this worktree, both builds fresh
against the rebased base: v6-dev sits at 137.90 KB against a 138 KB ceiling —
0.1 KB of headroom — and the change takes it to 138.02. `coreui.min.js` needed
no raise here: #1294 and #1296 had already taken it to 92 KB, and this lands at
91.10.

5661 of 6315 branches covered (89.64%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 5 files covered. (100.0%)

10955 of 11362 relevant lines covered (96.42%)

470.32 hits per line