coreui / coreui-pro / 34845396225

96%

main: 94%

push

github

refactor(Autocomplete, MultiSelect, pickers)!: the panel button is pickerIcon (#1290)

`indicator` named two unrelated things. On Autocomplete it was a boolean that
showed the button opening the options menu; on ListBox, Combobox and Transfer
it is a string choosing the marker drawn on each option. The button also
answered to three names across the family — `indicator`, `indicatorIcon`, and
`ariaIndicatorLabel` next to `ariaToggleLabel`.

The word stays where it describes something that indicates — the per-option
marker, which is also what Radix and Base UI call `ItemIndicator` — and the
button takes the name the platform gives it: `::picker-icon`, next to
`::picker(select)` for the panel and the older `showPicker()`.

  indicator: boolean                    -> pickerIcon: string | boolean
  indicatorIcon (four pickers)          -> pickerIcon
  ariaIndicatorLabel / ariaToggleLabel  -> ariaPickerLabel
  optionsStyle: 'checkbox' | 'text'     -> indicator: 'checkbox' | 'none'

`pickerIcon` does both jobs the old pair did: `false` renders no button, `true`
the built-in icon, a string your own inline SVG (sanitized). Autocomplete and
MultiSelect gained it — their icon was hard-coded — so their button is
configurable and removable for the first time. `true` exists because
Autocomplete defaults to no button, and `pickerIcon: 'false'` would otherwise
be the only way to ask for the default one.

Unchanged on purpose: `indicator` on ListBox, Combobox and Transfer with its
class and data attribute; PasswordInput's `ariaToggleLabel`, since that button
toggles visibility rather than opening a picker; and `.form-control-action`,
which eight components use for three different jobs, so it is a slot, not a
name for one of them.

The pickers' option blocks are sorted again — `pickerIcon` and
`ariaPickerLabel` land in different places than the names they replace, and
`calendarOptions` was already out of order.

5649 of 6303 branches covered (89.62%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 7 files covered. (100.0%)

10945 of 11352 relevant lines covered (96.41%)

470.05 hits per line