hyperledger-labs / fabric-smart-client / 34839576932

91%

Build Type

push

github

Committed by web-flow

Commit Message

lint: enable forcetypeassert and fix every flagged unchecked type assertion (#1821)

Every production-code finding (100 across 33 packages when the linter was
enabled) is fixed with a checked assertion: an error return for functions
that already report errors, panic for the ones that don't, and either
propagated to satisfy loop or bool-predicate conditions. Test fixtures and
the nwo integration harness are excluded since a mismatch there is a test
bug, not a security concern.

Also uses proto.CloneOf, a new generic panic-safe clone helper, in place of
proto.Clone(x).(*T) where that pattern showed up among the fixes.

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

223 of 401 new or added lines in 45 files covered. (55.61%)

3 existing lines in 2 files now uncovered.

27254 of 31936 relevant lines covered (85.34%)

2793.39 hits per line