IJHack / QtPass / 34836650519

93%

push

github

fix: surface unset executables instead of wedging the command queue (#1682) (#1691) (#1716)

* fix: surface unset executables instead of wedging the command queue (#1682)

* Address review: fall back to the filesystem when git is unconfigured

The executeGit() early return made Remove() and Move() silent no-ops with
useGit on and no git executable: the git branch was taken, executeGit()
bailed out, and the QFile/QDir fallback in the else branch never ran, so
the entry stayed on disk with no error shown. Insert()/Copy() encrypted but
never staged, and the toolbar pull/push did nothing.

Route every git-only branch through gitConfigured() (pure check, also used
per file inside the re-encryption worker) or gitReady() (same check plus a
one-line status message on the user-facing operations), so an unconfigured
git takes the plain filesystem path and the user is told why git was
skipped. executeGit() no longer swallows an empty executable; should one
still reach it, the Executor now reports it as an error instead of wedging
the queue.

Two integration tests drive Remove() and Move() with useGit=true and an
empty gitExecutable; both fail on the previous commit (file left on disk)
and pass now, and a following Insert() confirms the queue stays usable.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Backport to main (1.8.x) for #1709: hand-resolved src/imitatepass.cpp.
main has no re-encryption worker thread (#1697), so reencryptPath() is
still synchronous there; the autoPull/autoPush checks inside it and the
per-file/backup-commit checks were switched to gitConfigured() in place,
and Init() routes its existing gitAddGpgId() guard through gitReady()
instead of introducing the 2.0 useGit local. Executor and test hunks
applied unchanged.

(cherry picked from commit 60a0b4f15)

25 of 30 new or added lines in 2 files covered. (83.33%)

5018 of 7355 relevant lines covered (68.23%)

66.78 hits per line