coreui / coreui-pro / 34829201597

94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(DateRangePicker,TimePicker): restore the keyboard in a picker whose menu sits in a container (#1285)

Three defects, all from the same assumption that the menu lives inside the
component root. Setting `container` moves it to the container, and everything
that reaches for it through the root stops working.

Tab was dead. FocusTrap took every Tab once an additional element was
configured but only redirected focus at the four seams between the two groups,
so a Tab anywhere else was cancelled with nothing to focus. The first Tab after
opening targets the first field input, which is no seam, so the whole picker was
unreachable from the keyboard - measured as six consecutive presses leaving
focus on the input. The event is now taken only where focus is actually moved.

Escape did not close the picker. The listener is bound to the component root, so
a keystroke from a menu that no longer lives there never arrives; it is bound to
the menu as well when a container is configured.

Closing left focus on <body>. Only the Escape path restored it, and only in the
date range picker, so closing by picking a date - or by Escape in the time
picker - dropped the keyboard user out of the page flow. FocusTrap takes an
opt-in `returnFocus` instead: it remembers what was focused before it activated
and hands focus back on deactivate, as long as focus is still its own. Both
pickers opt in, which covers every close path at once. Modal and Offcanvas keep
the default and are unchanged.

The seam redirects, the trap's containment and the pickers' other close paths
are unchanged; new specs cover the middle-of-group Tab, the seam that must keep
working, the return target, and both container cases.

Coverage Stats

3970 of 4394 branches covered (90.35%)

Branch coverage included in aggregate %.

30 of 33 new or added lines in 3 files covered. (90.91%)

2 existing lines in 1 file now uncovered.

7326 of 7610 relevant lines covered (96.27%)

689.65 hits per line