coreui / coreui-pro / 34794451025

94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(OTPInput): namespace the paste listener, clear stale tab indexes (#1280)

Two defects.

`EVENT_PASTE` was declared as a bare `paste`, so the delegated listener carried
no namespace and `dispose()` — which clears `EventHandler.off(element,
EVENT_KEY)` — never reached it. A disposed control still intercepted a paste and
called preventDefault on it. The bare name was not carelessness: `paste` was
missing from `nativeEvents`, and a namespaced listener whose base type is absent
from that set registers for the literal string and never fires at all. That
entry arrived with the last sync, so the namespace works now.

`_setInputsTabIndexes` returned immediately when `linear` was off, which leaves
whatever tab indexes were already on the slots. Switching the option off through
`update()` therefore kept `tabindex="-1"` on every empty slot past the first,
and those slots stay unreachable by keyboard in a mode whose whole point is that
any slot can be typed into. The non-linear branch now clears the attribute
across the slots before returning.

Tests: switching linear off through `update()` puts every slot back in the tab
order, and a disposed control leaves a paste event alone. Both verified red
beforehand.

Coverage Stats

3939 of 4374 branches covered (90.05%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

7299 of 7593 relevant lines covered (96.13%)

682.19 hits per line