hyperledger-labs / fabric-smart-client / 34823441991
91%

DEFAULT BRANCH: main
Ran
Jobs 22
Files 505
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.717% (+0.04%) from 85.676%
34823441991

push

github

web-flow 
test(metrics/operations): replace the dead spec suite with real tests (#1815)

The package reported 0% coverage. system_test.go held 331 lines of
commented-out Ginkgo specs from #1017, where statsd support was dropped:
the statsd parts were deleted and the rest was commented rather than
removed. The Describe block stayed live and empty, so the suite passed
in about a second while exercising nothing and CI stayed green.

Those specs could not be restored. They call operations.NewSystem(opts),
Addr, RegisterHandler, RegisterChecker, Log and an exported Provider
field, none of which exist now, and they depend on fabhttp, healthz and
fakes types that were removed with them. They are deleted here, along
with the Ginkgo suite runner, and replaced with plain testify tests
against the current API.

Covers NewOperationSystem and the logspec handler it registers, the
RequireClientCert flag threaded through handler registration,
initializeMetricsProvider across its prometheus, disabled and unknown
branches, Start, and Stop before Start, after it and twice over. Also
covers metrics.go and logger.go, including the nil-logger fallback.

The package is at 97.1%. The remainder is NewOperationSystem's error
branch, which wraps a failure from initializeMetricsProvider -- that
function returns nil on every path today, so the branch is unreachable.

Fixes #1801

Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>

27138 of 31660 relevant lines covered (85.72%)

2352.93 hits per line

Coverage Regressions

Lines Coverage ∆ File
3
91.76
-1.76% platform/fabric/core/generic/ordering/bft.go
2
83.78
-1.35% platform/view/services/comm/host/websocket/ws/stream.go
2
85.14
-2.7% platform/fabric/core/generic/msp/idemix/cache.go
2
92.31
-1.4% platform/view/services/metrics/prometheus/provider.go
2
76.83
-0.61% platform/fabric/core/generic/msp/idemix/provider.go
2
50.0
-20.0% platform/view/services/storage/driver/sql/sqlite/errormapper.go
Jobs
ID Job ID Ran Files Coverage
1 itest-fabric-atsa - 34823441991.1 451
43.87
GitHub Action Run
2 itest-fabric-events - 34823441991.2 456
29.14
GitHub Action Run
3 itest-fabric-stoprestart - 34823441991.3 451
31.36
GitHub Action Run
4 itest-fabricx-iou - 34823441991.4 483
29.49
GitHub Action Run
5 itest-fabric-runtimeconfig - 34823441991.5 461
39.1
GitHub Action Run
6 itest-fabric-configupdate - 34823441991.6 461
39.02
GitHub Action Run
7 utest-extensions - 34823441991.7 8
53.18
GitHub Action Run
8 utest-postgres - 34823441991.8 496
9.74
GitHub Action Run
9 itest-fsc-pingpong - 34823441991.9 249
35.0
GitHub Action Run
10 itest-fabricx-atsa - 34823441991.10 483
30.82
GitHub Action Run
11 itest-fabric-twonets - 34823441991.11 451
29.3
GitHub Action Run
12 utest-root - 34823441991.12 496
80.92
GitHub Action Run
13 itest-fabric-iouhsm - 34823441991.13 461
39.9
GitHub Action Run
14 itest-fsc-stoprestart - 34823441991.14 245
33.64
GitHub Action Run
15 itest-fabric-iou-libp2p - 34823441991.15 461
36.77
GitHub Action Run
16 itest-fabric-atsachaincode - 34823441991.16 456
31.04
GitHub Action Run
17 itest-fabricx-simple - 34823441991.17 483
28.04
GitHub Action Run
18 itest-fabricx-multiendorsement - 34823441991.18 483
28.68
GitHub Action Run
19 itest-fabricx-configupdate - 34823441991.19 483
28.64
GitHub Action Run
20 itest-fabricx-deployment - 34823441991.20 483
28.62
GitHub Action Run
21 itest-fabric-iou - 34823441991.21 461
40.68
GitHub Action Run
22 itest-fsc-signedpingpong - 34823441991.22 243
31.72
GitHub Action Run
Source Files on build 34823441991