coreui / coreui-pro / 34790619290

94%

push

github

fix(Calendar,Rating): stop deferring a callback past dispose, stop stacking rating listeners (#1277)

Closes the PRO half of the dispose-leak entry; Sidebar, FocusTrap and Navigation
went in coreui#1191.

Calendar's `_updateCalendar` handed its callback to `setTimeout(callback, 1)`
with no handle kept. Nothing cancelled it, so `dispose()` could land between the
redraw and the callback, which then read fields the teardown had nulled. The
redraw is synchronous — `_createCalendar()` has already put the cells in the
document by the time it returns — so the callback runs inline now and the gap
is gone.

Rating rebuilt its markup in `update()` and `reset()` and called
`_addEventListeners()` each time. Those listeners are delegated on the host and
survive the rebuild, so every call stacked six more: after two updates one
change event fired the handler three times. The calls are gone; the constructor
registers them once, which is all that was ever needed.

Rating also never disposed the tooltips it creates per item. `_tooltip` holds
only the most recent one, so every earlier tooltip stayed instantiated against a
node that had been replaced. `_disposeTooltips()` walks the items and disposes
each, and runs from `update()`, `reset()` and a new `dispose()`.

Tests, each verified red beforehand: the calendar callback has already run when
`_updateCalendar` returns; one change event reaches the handler once after two
updates; a tooltip built for an item is gone once that item is replaced.

3924 of 4361 branches covered (89.98%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 2 files covered. (100.0%)

7275 of 7569 relevant lines covered (96.12%)

682.42 hits per line