coreui / coreui-pro / 34788785910

94%

push

github

fix(Autocomplete,MultiSelect): tear down the listeners on the child elements (#1275)

* fix(Autocomplete,MultiSelect): tear down the listeners on the child elements

Both controls build their UI as children of the host element and hang listeners
on those children. `BaseComponent.dispose()` clears
`EventHandler.off(this._element, EVENT_KEY)` — the host only — so everything on
the generated menu, toggler, indicator, text input, options list and cleaner
outlived the instance. Autocomplete's `dispose()` destroyed the Popper and
stopped there, which is why a disposed control still toggled on the indicator
and still selected options.

MultiSelect already tore its children down on dispose, but `update()` rebuilt
the control by removing the menu and unwrapping the host without clearing
anything first. That left the previous menu, wrapper and their listeners
registered — the registry holds a reference, so the detached nodes stayed alive
too — and an open control also leaked its Popper.

The teardown moves into `_destroySelect()`, which both `dispose()` and
`update()` now call. It also clears the host element, because `update()` calls
`_addEventListeners()` again: the keydown listener that opens the control from
the native select was being stacked, so after two updates one ArrowDown called
`show()` three times.

Tests: a disposed autocomplete ignores clicks on its indicator, options list and
cleaner; a native-select keystroke reaches `show()` once after two `update()`
calls. Both verified red beforehand. Full suite green — 46 files, 3046 tests.

* refactor(Autocomplete): move the teardown into _destroyAutocomplete

The same cleanup arrived in two shapes in one change: MultiSelect got a
`_destroySelect()` that both `dispose()` and `update()` call, while Autocomplete
kept the element loop inline in `dispose()`. Autocomplete now follows the same
convention — a private teardown named after the create method it undoes, sitting
directly above it, with `dispose()` red... (continued)

3924 of 4361 branches covered (89.98%)

Branch coverage included in aggregate %.

18 of 18 new or added lines in 2 files covered. (100.0%)

7269 of 7563 relevant lines covered (96.11%)

679.45 hits per line