IJHack / QtPass / 34789123766

93%

push

github

Flatpak: manifest, CI build, and the upstream metadata Flathub requires (#1680)

* Flatpak: manifest, CI build, and the upstream metadata Flathub requires

Closes the gap in #637: a working org.qtpass.QtPass Flatpak on the KDE
6.11 runtime, built and linted locally, running against a real store.

flatpak/org.qtpass.QtPass.yml
- git, pass, pwgen and qrencode bundled; GnuPG comes from the runtime
- the sandboxed gpg keeps its own keyring (--persist=.gnupg) and talks
  to the HOST gpg-agent through the read-only xdg-run/gnupg socket dir,
  so private keys, pinentry and smartcards stay on the host
- flatpak/gpg2 wrapper: gpg forwards its environment to the agent, and
  XAUTHORITY=/run/flatpak/Xauthority plus the Flatpak D-Bus address make
  the host pinentry fail with "could not connect to display"; the
  wrapper drops those two and fixes the 0755 --persist dir to 0700
- permissions need no Flathub linter exception: wayland/x11, network,
  ~/.password-store, xdg-run/gnupg:ro, tray. ssh and ~/.gnupg are left
  to the user (Flatseal); documented in flatpak/README.md
- file overlays for the metainfo, icon, main.cpp and qtpasssettings.cpp
  because v1.8.0 predates the changes below; drop them at the next tag

Upstream changes Flathub wants integrated rather than patched:
- qtpass.appdata.xml: desktop-application, id org.qtpass.QtPass with
  <provides> for the old qtpass.desktop id, launchable, developer id,
  GPL-3.0-or-later, OARS content rating, url types, branding colours,
  release notes for 1.8.0 (appstreamcli validate clean)
- artwork/qtpass-icon.svg: square canvas (the original is 120x132 and
  Flatpak rejects non-square icons), named after the desktop Icon= key
- main/main.pro installs desktop file, metainfo and icons, not only the
  binary
- main.cpp: setDesktopFileName follows FLATPAK_ID inside a sandbox so
  Wayland compositors find the renamed desktop file
- QtPassSettings::initExecutables falls back to "gpg" when "gpg2" is
  absent, matching the ... (continued)

1 of 3 new or added lines in 1 file covered. (33.33%)

4658 of 7229 relevant lines covered (64.43%)

60.49 hits per line