coreui / coreui-pro / 34780529667

95%

main: 94%

push

github

fix(Dropdown, Popup)!: stop mirroring the alignment that Floating UI mirrors (#1268)

`@floating-ui/core` mirrors `-start`/`-end` itself when the floating element
resolves to RTL, and `@floating-ui/dom` implements the `isRTL` platform hook,
so a placement handed to it is already logical. We flipped the alignment first,
and two mirrors give the original: in `dir="rtl"` a default dropdown opened
against the LEFT edge of its toggle, the way it does in LTR.

Measured in Chromium, anchor centred so neither `shift()` nor `flip()` decides
the result:

  before  placement=bottom-end    panel[l=901 r=1161]  toggle[l=901 r=948]  left edge
  after   placement=bottom-start  panel[l=688 r=948]   toggle[l=901 r=948]  right edge

Gone: the alignment flips in `dropdown.ts`, the hardcoded one in
`util/floating-ui.ts`, and `Popup._resolvePlacement`. `getDefaultPlacement()`
went with them — it had no callers left.

Kept, because Floating UI does not mirror sides: `PLACEMENT_RIGHT` /
`PLACEMENT_LEFT` for dropend/dropstart, Tooltip's `RIGHT`/`LEFT`, and
`resolveLogicalPlacement` in Menu, which maps the logical side names
`start`/`end` onto `left`/`right` — names the library does not understand.

5597 of 6238 branches covered (89.72%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

10877 of 11280 relevant lines covered (96.43%)

467.18 hits per line