stillwater-sc / universal / 34761513466

86%

master: 84%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(elreal): split elreal into core / manipulators / iostream (#1334) (#1465)

* refactor(elreal): split elreal into core / manipulators / iostream (#1334)

Fourth and last type of Phase 2 group 5b (#1455).

    core.hpp     94,744 lines / 413 headers / 1 I/O-family (<ostream>)
    elreal.hpp  116,357 lines / 524 headers / 5 I/O-family  (was 142,929 / 705 / 5)

THE CORE REACHES 1 OF 5, NOT 0, AND NO HEADER SPLIT CAN FIX IT. Reporting the
number rather than moving the bar: ZBCL nodes are std::shared_ptr and the thunks
std::function, and libstdc++ 13's <memory> itself includes <ostream> -- 53,429
lines, before a line of Universal. <iostream>, <sstream>, <iomanip> and <istream>
are all gone. This is the same kind of floor <complex> sets for every mathlib
(it pulls <sstream>): a property of the standard library, not of the layering.
Getting under it means replacing shared_ptr in the co-list, which is a design
change, not a layering one. The line count is set by the same things: <memory>,
<functional> and integer's core (the 256-bit block exponent) are 80,677 lines
together.

elreal's own code was already clean

Its text was already confined to manipulators.hpp and block_manipulators.hpp.
What put all five I/O-family headers into every elreal translation unit was the
types it is built from, reached by their UMBRELLAS:

- block.hpp included integer/integer.hpp for exp_t, the integer<256> exponent
  (#1061) -> integer/core.hpp.
- round.hpp included dd.hpp, qd.hpp and cfloat.hpp for round_to's targets ->
  their cores. round_to only converts into those types; it never formats them.

All four have had cores since group 4; this is the substrate-first rule paying
out. Two consequences the build found:

- block_manipulators.hpp streams the integer<256> exponent (`s << b.exp`), and
  operator<< for integer is in integer's text layer. It used to arrive with the
  integer umbrella through block.hpp; block_manipulators.hpp now includes
  integer/iostream.hpp its... (continued)

Coverage Stats

7 of 7 new or added lines in 1 file covered. (100.0%)

18 existing lines in 2 files now uncovered.

43267 of 50504 relevant lines covered (85.67%)

7163467.01 hits per line