stillwater-sc / universal / 34759498803

86%

master: 84%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(ereal): split ereal into core / manipulators / iostream (#1334) (#1461)

* refactor(ereal): split ereal into core / manipulators / iostream (#1334)

Third type of Phase 2 group 5b (#1455).

    core.hpp     70,745 lines / 355 headers / 0 I/O-family
    ereal.hpp    85,160 lines / 427 headers / 5 I/O-family  (was 104,596 / 454 / 5)

Zero I/O-family headers is met. Under-45,000 lines is not, and reporting the
number rather than moving the bar: internal/expansion/expansion_ops.hpp -- the
Shewchuk expansion arithmetic ereal is built from -- is 49,717 lines on its own
(already 0 I/O), and native/ieee754_core.hpp (43,486) supplies isinf/isnan. The
umbrella's fall is mostly an unused <regex> (78,114 lines, <sstream> included).

The core was not self-sufficient -- the gate found it

parse() and to_digits() call pown(ereal, int) and ldexp(ereal, int), and both
were defined in the MATHLIB. On main that works only because the umbrella
includes mathlib.hpp after the impl and the calls are dependent, so ADL finds the
definitions at instantiation. A translation unit including core.hpp alone
compiled cleanly under -fsyntax-only and failed the moment the gate instantiated
to_string(). The same trap bfloat16's isinteger() -> floor() hit (#1445).

- pown(ereal, int) moves from mathlib.hpp into ereal_impl.hpp, beside abs(). That
  is where dd keeps its pown, for the same reason. mathlib.hpp now includes the
  core, so everything that saw pown before still does.
- core.hpp includes math/functions/numerics.hpp -- ldexp, frexp, copysign,
  scalbn, logb, ilogb, fma: 109 lines of pure computation, I/O-free.

The trace

to_string(), to_digits() and round_string() carry ten trace statements behind
`if constexpr (bTraceDecimalConversion)` / `(bTraceDecimalRounding)`. A discarded
branch still needs std::cout DECLARED, so they now write through
std::fprintf(stdout, ...) -- exactly what dd, whose to_string this code was
ported from, already does. The two static constexpr ... (continued)

Coverage Stats

39 of 48 new or added lines in 3 files covered. (81.25%)

1 existing line in 1 file now uncovered.

43285 of 50504 relevant lines covered (85.71%)

7163345.35 hits per line