stillwater-sc / universal
86%
master: 84%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Repo Added
Files 673
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 85.897% (+0.02%) from 85.882%
35364986399

push

github

web-flow 
fix: ereal overflow and large-dividend division, areal to_string (#1555)

Two finite ereal operands whose result lies beyond double's range came back
as NaN in every limb -- DBL_MAX + DBL_MAX was [nan, nan] -- because the
special-value guards from #966 see only the operands: the error-free
transformation rounded its leading term to inf, computed the roundoff as
inf - inf = NaN, and renormalization spread it everywhere (#1553).

The regression for that found a second defect: expansion_quotient scaled the
divisor into [0.5, 1) but never the dividend, so dividend * reciprocal
overflowed for any dividend above about DBL_MAX / 2. DBL_MAX / 2 and even
DBL_MAX / 1e10 were NaN.

A check on a leading-term estimate in ereal's operators was tried first and
dropped: it reported the division NaN as inf, and flagged boundary values
such as (DBL_MAX / 3) * 3 as overflowing when the negative tail brings them
back into range. Only the full expansion knows. So the sum, product and
quotient now manage their own range: near the top they scale their operands
down by an exact power of two, compute, and scale back, returning a single
signed infinity when the leading component overflows on the way back.
Below the thresholds every path is bit-identical to what it was.

to_string(areal) returned an empty string for every value but zero and
infinity, its rendering line commented out. It now renders what operator<<
does, [v] or (v, next), repeated rather than borrowed so the manipulator
layer does not depend on the stream layer (#1554).

Six mutations of the fixed code were each caught by the new tests.

BEHAVIOUR-CHANGE: ereal arithmetic that overflows gives a signed infinity
instead of NaN in every limb; ereal division of a dividend above 2^1000
gives the quotient instead of NaN; to_string(areal) renders the value
instead of an empty string

Resolves #1553
Resolves #1554

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

39 of 39 new or added lines in 3 files covered. (100.0%)

8 existing lines in 1 file now uncovered.

44890 of 52260 relevant lines covered (85.9%)

8767847.4 hits per line

Relevant lines Covered
52260 RELEVANT LINES 44890 COVERED LINES
8767847.4 HITS PER LINE
Source Files on Ravenwater-patch-1

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
35364986399 main fix: ereal overflow and large-dividend division, areal to_string (#1555) Two finite ereal operands whose result lies beyond double's range came back as NaN in every limb -- DBL_MAX + DBL_MAX was [nan, nan] -- because the special-value guards from... push web-flow github
85.9
35360572437 fix/ereal-overflow-areal-to-string Merge b61ab61ca into 5fb30354e Pull #1555 web-flow github
85.9
35352604718 main fix: ereal integer conversion and pown, posit text functions (#1552) Two ereal defects and three posit ones, batched for one CI round. ereal's convert_signed() and convert_unsigned() were `// TBD` for every non-zero value, and all ten integer co... push web-flow github
85.88
35348753988 fix/ereal-posit-batch Merge cde64eea9 into c1eae715f Pull #1552 web-flow github
85.87
35320181350 main fix: five small manipulator and stream-extraction defects (#1551) Batched because each is a handful of lines in its own header and splitting them would cost five CI rounds. Each changes observable behaviour, and each arrived with a decision its i... push web-flow github
85.82
35317085553 fix/small-manipulator-io-defects Merge f83fb94ad into b3c9f93ff Pull #1551 web-flow github
85.84
35295045289 main fix(utility): make TrackedBounded's enclosure real and correct the tracker metrics (#1549) TrackedBounded computed its bounds by switching the FPU rounding mode with fesetround, without a FENV_ACCESS pragma that GCC or Clang honour. An optimizing... push web-flow github
85.78
35292203164 fix/issue-1544-tracker-defects Merge 3a198c6ca into b6e80bc45 Pull #1549 web-flow github
85.8
35289166259 fix/issue-1544-tracker-defects Merge 61a7bbe81 into b6e80bc45 Pull #1549 web-flow github
85.81
35281425776 main test(utility): give the tracked* suites real checks (#1548) The six test_tracked* files printed their results and returned 0 with no assertions, so in CI they could only catch a compile error or a crash. Any wrong number passed. Rewrite them on ... push web-flow github
85.82
See All Builds (1476)