stillwater-sc / universal / 34734291131

86%

master: 84%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(dbns): split dbns into core / manipulators / iostream / debug (#1334) (#1449)

* refactor(dbns): split dbns into core / manipulators / iostream / debug (#1334)

Fourth type of Phase 2 group 5a (#1444), and the first in the group where the
core's I/O was structural rather than an include.

    core.hpp        73,581 lines / 361 headers / 0 I/O-family
    dbns.hpp        82,967 lines / 392 headers / 5 I/O-family  (was 83,961 / 406 / 5)

Zero I/O-family headers is met. Under-45,000 lines is not, and reporting the
number rather than moving the bar: internal/blocktriple/blocktriple.hpp, which
dbns converts through, is 69,758 lines on its own (already 0 I/O), so this core
is blocktriple plus about 3,800 lines. The ceiling belongs to the substrate.

Four things had to move, and only the first is an include shuffle:

1. to_binary() formats through a stringstream -> manipulators.hpp.

2. operator<< and operator>> were in-class friend DEFINITIONS. An in-class friend
   definition pins <iostream> into every translation unit that includes the
   class -- the trap blockdigit and floatcascade were fixed for. Both go through
   dbns's public double conversion and assignment and need no private access, so
   they are now ordinary namespace-scope templates in iostream.hpp rather than
   friends in the class.

3. debugConstexprParameters() -- 22 std::cout statements in a member function --
   is declared in the class and defined out-of-line in debug.hpp. Same shape
   blocktriple's constexprClassParameters() got in #1388: forgetting the include
   is a link error naming the missing function, which is the better failure.

4. convert_ieee754's (a,b) search traced behind `if constexpr (bDebug)`. A
   discarded if-constexpr branch still requires std::cout to be DECLARED, so the
   three trace sites are now behind a DBNS_TRACE_CONVERSION preprocessor switch.

   bDebug was a local `constexpr bool bDebug = false;` that no caller could
   reach -- tracing could not b... (continued)

Coverage Stats

40 of 41 new or added lines in 3 files covered. (97.56%)

43 existing lines in 1 file now uncovered.

43195 of 50422 relevant lines covered (85.67%)

7175185.56 hits per line