stillwater-sc / universal / 34733638818

86%

master: 84%

push

github

refactor(dfloat): split dfloat into core / manipulators / iostream (#1334) (#1446)

* refactor(dfloat): split dfloat into core / manipulators / iostream (#1334)

Second type of Phase 2 group 5a (#1444), and it needed a substrate split first.

    core.hpp        58,787 lines / 295 headers / 0 I/O-family
    dfloat.hpp      76,512 lines / 377 headers / 5 I/O-family  (was 77,924 / 390 / 5)

Zero I/O-family headers, the binary criterion, is met. The under-45,000-lines
criterion is NOT, and reporting the number rather than moving the bar: the two
shared substrates a dfloat core cannot do without -- native/ieee754_core.hpp at
43,486 and internal/blockbinary/to_decimal.hpp at 33,308 -- already total 44,846
together, before dfloat contributes a line. That ceiling belongs to the
substrate, not to this type. For scale, the merged cores sit at cfloat 78,330,
fixpnt 78,123, posit 77,430, lns 74,762.

Substrate: internal/blockbinary/to_decimal.hpp (new)

to_decimal() builds its result by prepending characters to a std::string and
never opens a stream, but it shared manipulators.hpp with type_tag, to_binary and
to_hex, which do -- 50,808 lines and four of the five I/O-family headers. dfloat's
str() renders its significand with to_decimal(), and str() is core by the layer
contract, so the core could not reach zero while that function was trapped in a
streaming header. Split out: 33,308 lines, 0 I/O. manipulators.hpp includes it, so
every existing caller is unaffected. This is the rational precedent (#1425) taken
one step further -- rational could move its only consumer out of the core, dfloat
cannot.

What moved in dfloat:

- to_binary() and to_native() format through a stringstream -> manipulators.hpp.
- operator<< and operator>> -> iostream.hpp, which includes only core.hpp:
  operator<< formats through the core member str() and operator>> hands its token
  to parse(), so unlike bfloat16 there is no dependency on manipulators at all.
- parse() STAYS in the core. ... (continued)

67 of 68 new or added lines in 3 files covered. (98.53%)

43193 of 50420 relevant lines covered (85.67%)

7175507.73 hits per line