bleedingdeacons / fellowship / 34711003177
91%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 58
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 90.635%. Remained the same
34711003177

push

github

web-flow 
fix: unslash $_POST, so a valid service account can actually be saved

Pasting a Firebase service account into Settings answered "That does not
look like a Firebase service-account JSON file. Nothing was changed." for
every correct file. It was never the file.

WordPress runs wp_magic_quotes() over $_POST on every request, so the
handler received the paste with every quote as \" and every escape
doubled. json_decode refused it, ServiceAccount::fromJson() answered null,
and saveFromRequest() returned bad_service_account -- before writing any
of the other fields, which is why "nothing was changed" was literally
true and a retention edit in the same submit was silently dropped too.

No correct service account could be stored through that screen on any
site. On the test bed the column had simply never been populated, and
push had therefore never once been attempted: FcmTransport::account()
answers null and MessageDispatcher gives up before touching a handset.
Both handsets were enrolled with valid tokens throughout.

wp_unslash() now wraps every read in the handler, not just this one. The
others are slashed identically and never showed it because client ids and
OAuth secrets are alphanumeric with dashes, which addslashes leaves
untouched -- but a secret containing a quote would have been stored
corrupted and then silently failed to authenticate, which is worse than
being refused.

Two tests, and the point of both is that they set $_POST the way the
runtime really does. Every existing test on this handler assigns $_POST by
hand, unslashed, which is exactly how a handler that could not save
anything kept a green suite. Verified red before this change and green
after: the service-account case fails with 'bad_service_account' where
'saved' was expected, reproducing the reported message precisely.

3252 of 3588 relevant lines covered (90.64%)

6.44 hits per line

Coverage Regressions

Lines Coverage ∆ File
6
95.07
0.0% fellowship/fellowship/src/Admin/SettingsPage.php
Jobs
ID Job ID Ran Files Coverage
1 34711003177.1 58
90.64
GitHub Action Run
Source Files on build 34711003177