bleedingdeacons / fellowship / 34706978106
90%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 58
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 90.635% (-0.2%) from 90.871%
34706978106

push

github

web-flow 
feat: say why a handset can only poll, instead of only that it can

The Devices screen has always shown "Poll only", and that is a diagnosis
with the cause left off. All three conditions behind wantsPush() are
ordinary states a real handset passes through, and they call for
completely different things: a missing token normally fixes itself the
moment Firebase answers, no transport at all means the handset enrolled
claiming none, and a missing public key is a row nothing sealed can ever
be sent to. Told only that push is off, everybody guesses "Firebase is
broken" and goes to the console.

Device::pushBlocker() names which, the admin table prints it beside "Poll
only", and MessageDispatcher reports it once per message rather than once
per handset -- the same argument the service-account check above it
already makes, and a broadcast to a large fellowship is exactly where a
line per device stops being read.

Nothing branches on the string; it is phrased for whoever is reading the
table or the log, and a test pins it to wantsPush() so the two cannot
drift apart and have the table and the log disagree.

Found chasing a broadcast that reached neither test handset. Delivery
turned out to be fine -- both collected it on a pull-to-refresh -- and the
gap was that a phone left idle looks identical whether push was never
attempted or was attempted and lost, with nothing written down either way.

3252 of 3588 relevant lines covered (90.64%)

6.42 hits per line

Coverage Regressions

Lines Coverage ∆ File
10
93.87
-0.82% fellowship/fellowship/src/Admin/DevicesPage.php
9
81.67
-14.08% fellowship/fellowship/src/Messaging/MessageDispatcher.php
Jobs
ID Job ID Ran Files Coverage
1 34706978106.1 58
90.64
GitHub Action Run
Source Files on build 34706978106