bleedingdeacons / fellowship / 34693935405
90%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 58
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 90.806% (-0.4%) from 91.216%
34693935405

push

github

web-flow 
feat: say which refusal it was, when saying so is safe (#18)

CurrentDevice answers null for every refusal without distinguishing
between them, and the reasoning for that is right: telling an
unauthenticated caller which of its guesses was closest is how enrolled
addresses get enumerated.

It does not apply to a caller who has proved something. A request whose
bearer token matched a live device row already holds a credential this
site issued; being told the member behind it is no longer one Fellowship
will talk to reveals nothing it did not have, and cannot be used to probe
a second address, because a token is bound to the one device it was
minted for.

So exactly one case is separated out. A token that matched a live row
whose member the gate then refused answers 403 fellowship_not_a_member.
Everything else -- no header, a malformed token, an unknown one, a
revoked one -- stays the generic 401 and stays indistinguishable.

What it is for is on the handset. Link rendered every refusal as
"could not be reached", so a member whose record had changed in Unity was
told to check their signal about a phone that was working perfectly.
Link's companion change reads this and says which.

CurrentDevice::resolve() is the new entry point and fromRequest() is now
a wrapper over it, so the call sites that have nothing different to do
about a 401 than a 403 are untouched.

3200 of 3524 relevant lines covered (90.81%)

6.38 hits per line

Coverage Regressions

Lines Coverage ∆ File
9
58.33
-7.18% fellowship/fellowship/src/Rest/DirectoryController.php
5
96.82
0.12% fellowship/fellowship/src/Rest/MessageController.php
Jobs
ID Job ID Ran Files Coverage
1 34693935405.1 58
90.81
GitHub Action Run
Source Files on build 34693935405