34694062992
90%

Ran 12 Sep 2026 12:38PM UTC

Jobs 1

Files 58

Run time 1min

Badge

Embed ▾

Committed 12 Sep 2026 12:34PM UTC coverage: 90.806%. Remained the same

Build # 34694062992

Build Type

push

github

Committed by

web-flow

Commit Message

docs: correct what a lost device key actually costs (#19)

Two docblocks here claimed that a message sealed to a handset's public
key can be opened by that handset and by nothing else, this server
included, and that a rotation therefore leaves everything sent before it
permanently unreadable.

The first half is true of an envelope. Neither is true of a message.
MessageController::inbox seals on every fetch, from a body stored as
plain TEXT, to whichever public key the asking device presents. So this
server can and does seal the same message to a new key the moment one is
presented, and a rotation loses nothing the retention window still
covers.

What is genuinely lost is narrower: messages the sweep has already taken,
and any push sealed and sent before the change, because nothing re-sends
a push.

The correction matters beyond accuracy. The old comment sat directly
above rotateKey() and made key substitution read as harmless -- the route
authenticates on the bearer token alone, and substituting the key is
enough to have every retained message re-sealed to it. That is now said
where somebody deciding whether to tighten the route will read it.

Link carries the same correction; the wrong version had reached six files
across the two repositories.

No behaviour change.

Coverage Stats

3200 of 3524 relevant lines covered (90.81%)

6.38 hits per line

Coverage Regressions

Lines	Coverage	∆	File
8	96.6	0.0%	fellowship/fellowship/src/Rest/DeviceAuthController.php

Jobs

ID	Job ID	Ran	Files	Coverage
1	34694062992.1	12 Sep 2026 12:38PM UTC	58	90.81	GitHub Action Run

bleedingdeacons / fellowship / 34694062992
90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 34694062992

bleedingdeacons / fellowship / 34694062992 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 34694062992

bleedingdeacons / fellowship / 34694062992
90%

README BADGES
x