ruby-grape / grape / 34613907687

99%

master: 99%

Build Type

Pull #2936

github

Committed by ericproulx

Commit Message

Speed up header versioning, content negotiation, params validation and error responses

Thirteen request-path changes, each measured on its own and together:

Versioning and content negotiation
- Header versioner: answer the Accept headers most requests send (every
  declared media type, */*, none) from a table built once per list of
  media types and shared through Grape::Util::Cache, instead of running
  Rack::Utils.best_q_match and MediaType.parse per request. MediaType is
  now immutable, so the api.* env strings it writes are frozen
  (UPGRADING).
- Versioners read cascade/parameter/strict/vendor off instance variables
  instead of two Forwardable hops and two Data readers.
- Formatter: the same kind of shared table for Accept-negotiated formats
  when no format is pinned.

Params validation
- A required, dependency-free Hash scope (the root scope included) is
  validated without the attributes iterator, and skips should_validate?,
  which always answers true for it.
- So are the elements of an Array scope that is the only one iterating
  elements on such a chain, required or optional.
- The attributes iterator settles its per-scope state once per pass.
- qualifying_params returns early for scopes other than `given`.
- declared skips the renamed-params lookup when nothing is renamed.
- DryTypeCoercer uses dry-types' non-raising block form, so a rejected
  value no longer builds a re-raised backtrace.

Error responses
- The default rescue handler no longer reads the exception's backtrace
  unless one is asked for.
- Formatter lets a parser's Grape errors through without re-raising them.
- rack_response hands its fresh headers to Rack::Response as they are,
  Method rescue handlers are called directly, and ensure_utf8 returns a
  valid UTF-8 message as it is.
- ValidationErrors#full_messages is translated once instead of on every
  call.

Adds specs for behaviour the changes brought to light and nothing
pinned, each found by a mutation that passed ... (continued)

Pull Request Pull Request #2936: Speed up header versioning, content negotiation, params validation and error responses

Coverage Stats

1343 of 1390 branches covered (96.62%)

Branch coverage included in aggregate %.

104 of 104 new or added lines in 12 files covered. (100.0%)

1 existing line in 1 file now uncovered.

4106 of 4107 relevant lines covered (99.98%)

26733.28 hits per line