ruby-grape / grape / 34515497970

99%

push

github

Pin the router's regressions through requests, not its instance variables (#2921)

Three specs in spec/grape/router_spec.rb reached into the router with
`instance_variable_get`: two asserting that `@map` and `@optimized_map` are
frozen and gain no key when a method with no routes is routed (#2790), and
one asserting that `@optimized_map` has a key for a non-standard verb
(#2886). They pinned where the router keeps its state rather than anything a
caller can see.

The #2886 regression is already caught by its behavioural sibling in the
same block -- a PURGE route left out of the optimized map answers 404
instead of 200 -- so that spec goes.

For #2790, the maps being frozen is what makes the bug observable: an
auto-vivifying lookup on a frozen Hash raises instead of silently inserting a
key. The spec now routes POST, PUT, PROPFIND and CUSTOM -- the methods the
old one used -- through a compiled router, frozen as Grape::API::Instance
leaves it, and expects the default 404 for each; it absorbs the POST-only
example that sat beside it. Reintroducing the auto-vivifying map fails all
four examples with FrozenError, and so does any request-time write to the
router's own instance variables, which the old specs could not see.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1306 of 1350 branches covered (96.74%)

Branch coverage included in aggregate %.

4039 of 4039 relevant lines covered (100.0%)

27246.42 hits per line