coreui / coreui-pro / 34601077892

96%

main: 94%

push

github

feat(DatePicker): compose from the markup and own the date (#1244)

* feat(DatePicker): compose from the markup and own the date

The picker is now one piece of state — the date — joining the date
input, the calendar and the popup. `_applyDate()` is the only place the
date changes: it writes to the field, reads back what the field kept
after validation, updates the calendar and emits `dateChange` once, when
the value moved. The side that reported a change is not written back to,
which replaces the `_syncingFromPanel` echo guard; `setDate`, `clear`,
`reset` and `today` all go through it.

The markup is the composition surface. A `div` marked
`data-coreui-picker-field`, a `data-coreui-picker-toggle` and a
`data-coreui-picker-cleaner` inside the picker element are adopted in
place of the generated parts, so the trigger can be a plain button with
text and the icons plain `<svg>` in the HTML; a missing part is still
generated, so the bare `<div data-coreui-toggle="date-picker">` is
unchanged. An adopted element gets the accessibility the component
would have given its own: `ariaToggleLabel` / `ariaCleanerLabel` as its
name unless it has one, `aria-hidden` on its decorative SVG, `disabled`
with the picker. `aria-expanded` moves from the root to the toggle,
which also carries `aria-controls` and `aria-haspopup="dialog"`.
dispose() removes only what the picker built.

* chore: raise the JavaScript bundlewatch budgets by 0.5 KB

Composing the date picker from the markup it is given adds the field,
toggle and cleaner lookups plus the aria wiring, which pushed
coreui.esm.js, coreui.esm.min.js and coreui.min.js past their ceilings
by 10-170 bytes. The three remaining JavaScript bundles had zero
headroom left, so they move with them instead of blocking the next PR.

5605 of 6254 branches covered (89.62%)

Branch coverage included in aggregate %.

63 of 64 new or added lines in 1 file covered. (98.44%)

10862 of 11267 relevant lines covered (96.41%)

458.84 hits per line