hyperledger-labs / fabric-smart-client / 34591768758

91%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(fabric): simplify CFTBroadcaster retry loop, fix connection-pool leaks (#1808)

Broadcast tracked retry state through a forceConnect flag and a
connection variable reused across loop iterations, splitting a single
logical "get a connection, send, receive" step across four different
branches. Extracts the send/receive pair into a sendAndRecv helper and
lets each retry acquire its own connection up front, so the loop body
reads as one attempt per iteration instead of a state machine.

Fixes connection-pool resource leaks in getConnection: all four error
returns after a successful connSem.Acquire (no orderer configured,
client creation, broadcast-client creation, stream creation) never
released the acquired semaphore slot, and the broadcast-client-creation
failure additionally never closed the already-created client, unlike
its sibling stream-creation failure a few lines below. Each lost slot
permanently shrinks the pool, and enough connection failures would
eventually deadlock every future Broadcast call waiting on the
semaphore.

Adds regression tests: one drives poolSize consecutive failures of
each of the four getConnection failure kinds and confirms the pool
still yields poolSize semaphore slots afterward (verified against the
pre-fix code), and one covers the zero-retries case, where the old
code's uninitialized error left errors.Wrap(nil, ...) returning nil
and Broadcast silently reporting success without ever attempting to
send.

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

23 of 23 new or added lines in 1 file covered. (100.0%)

4 existing lines in 2 files now uncovered.

27126 of 31660 relevant lines covered (85.68%)

2757.98 hits per line