ruby-grape / grape / 34589558549

99%

master: 99%

Pull #2935

github

Return the elements of an Array params scope that are not a Hash from declared

`declared` filters each element of an Array scope down to its declared
keys by building an empty copy of the element (`passed_params.class.new`)
and filling it. An element that is not a Hash has no keys, and copying it
raised: `NoMethodError` for `nil`, `false` and numbers, and a `TypeError`
for a String, which then got indexed with a Symbol. The request answered
500.

Validation lets such an element through wherever nothing in the scope is
required of it:

    optional :items, type: Array do   # blank elements are passed over
      requires :id, type: Integer
    end

    requires :tags, type: Array do    # nothing to check on a non-Hash
      optional :label, type: String
    end

so `{"items": [null, {"id": 1}]}` or `{"tags": ["x", {"label": "y"}]}`
got past validation and then broke the endpoint calling `declared`.

Such an element is now returned as it came in, the way a leaf value is.
The test is `respond_to?(:key?)`, the one `declare_leaf` already uses, so
a Hash-like object that is not a Hash is still filtered.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1309 of 1352 branches covered (96.82%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

4040 of 4040 relevant lines covered (100.0%)

27288.65 hits per line