ruby-grape / grape / 34586529390

99%

master: 99%

Pull #2933

github

Validate the elements of an Array params scope without the attributes iterator

A validator on `requires :items, type: Array do ... end` (or `optional`)
went through the AttributesIterator for every element: an index
bookkeeping call, a yield per attribute, an emptiness test, and per
attribute the scope's `required?` and `meets_dependency?`. When the scope
depends on no other param, every scope above it is always validated, and
it is the only one on the chain that iterates elements, those answers are
fixed: its params are the request's Array as it came in, and the iterator
only contributes the element index the error names carry and, for an
optional scope, passing over empty elements.

`Validators::Base#validate_elements!` covers that case the way #2927's
`validate_attributes!` covers a Hash scope. `ParamsScope#validated_when_given?`
names the condition, and `always_validated?` is that plus being required;
a required scope like that also skips `should_validate?`, which always
answers true for it. Nested Array scopes and `given` blocks keep the
iterator.

Adds three specs for behaviour nothing pinned, each found by a mutation
that passed the suite: an optional Array scope skips its empty elements,
it is not validated at all when every element is blank, and a Hash scope
given an Array reports only itself, not the optional Array scope inside.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1328 of 1374 branches covered (96.65%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 2 files covered. (100.0%)

4070 of 4070 relevant lines covered (100.0%)

26888.74 hits per line