ruby-grape / grape / 34523953235

99%

master: 99%

Pull #2927

github

Validate required Hash params scopes without the attributes iterator

Most validators of most endpoints sit on the root `params` scope or a
required Hash scope under it, and for them `Validators::Base` ran the
generic machinery: `should_validate?`, which resolves the scope's params
and walks the parent chain, then an `AttributesIterator` pass that
resolves the params again, checks for arrays and the empty-optional
sentinel and yields once per attribute, then a block that re-checks the
scope's requiredness and dependency. For a root-scope validator that
plumbing took about 570 of its 840 ns; a nested one paid more.

When a scope and every one of its ancestors is required and depends on
nothing, `should_validate?` is true for every request and has no side
effects; `ParamsScope#always_validated?` answers that. If the scope also
does not iterate elements and its params resolve to a Hash, the iterator
path reduces to: for each attribute, `validate_param!(attr, params)` if
it is required or present. `#validate` skips `should_validate?` for such
a scope, and `#validate!` resolves the params once and runs that loop.
Array scopes, `given`, optional scopes and their descendants, and params
that resolve to something other than a Hash keep the existing path.
`DefaultValidator` and the multiple-params validators, which override
`#validate!`, only skip `should_validate?`.

The flag is set in `#initialize`, since validators are frozen once
built. A scope's parent, optionality, dependency and type are fixed
before its block declares anything, so it is final by then.

An Array group handed a Hash reporting only its own type error, without
its members being validated against the Hash, had no spec; routing that
case through the new path passed the whole suite. It now has one.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1314 of 1358 branches covered (96.76%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 2 files covered. (100.0%)

4050 of 4050 relevant lines covered (100.0%)

26911.37 hits per line