ruby-grape / grape / 34583713801

99%

master: 99%

Pull #2933

github

Validate the elements of a required Array params scope without the attributes iterator

A validator on `requires :items, type: Array do ... end` went through the
AttributesIterator for every element: an index bookkeeping call, a yield per
attribute, an emptiness test, and per attribute the scope's `required?` and
`meets_dependency?`, plus a `should_validate?` walk up the scope chain before
any of it. When every scope on the chain is required with no dependency and
this is the only one that iterates elements, those answers are fixed: the
scope's params are the request's Array as it came in, and the only thing the
iterator still contributes is the element index the error names carry.

`Validators::Base#validate_elements!` covers that case the way #2927's
`validate_attributes!` covers a Hash scope: it records each index and runs
the same per-attribute check. Nested Array scopes, optional ones and `given`
blocks keep the iterator.

Adds a spec that an optional Array scope skips its empty elements: nothing
pinned that, and letting optional scopes take the new path passed the suite.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1324 of 1368 branches covered (96.78%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 2 files covered. (100.0%)

4062 of 4062 relevant lines covered (100.0%)

26840.49 hits per line