hyperledger-labs / fabric-smart-client / 34574819854

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric): bound the remote finality probe by the caller's context (#1810)

Committer.IsFinal documents the caller's context as bounding the whole wait, and
its first and third stages honour it. The remote peer probe did not: it built its
own context from context.Background(), so it ran the full WaitForEventTimeout
regardless of the caller's deadline, and cancelling the caller's context did not
stop it. A caller asking for 5s on a channel configured for 120s waited ~120s and
then reported a deadline error that looked like a slow orderer.

FabricFinality.IsFinal now takes a context and derives the probe's context from
it, so WaitForEventTimeout stays a ceiling that an earlier caller deadline wins
against.

docs/configuration.md records that the probe and the local event wait run in
sequence, so finality.waitForEventTimeout and committer.waitForEventTimeout add
up rather than being alternatives.

Fixes #1735

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

2 of 2 new or added lines in 2 files covered. (100.0%)

9 existing lines in 3 files now uncovered.

27087 of 31662 relevant lines covered (85.55%)

2757.47 hits per line