hyperledger-labs / fabric-smart-client / 34539400622

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric): do not wrap a nil err as if it were the failure cause (#1807)

Fixes a fuzz-found nil-pointer panic in transaction.UnpackEnvelopePayload
(fixes #1806): a nil-check branch wrapped an already-nil err via
errors.Wrap, which returns nil on a nil error, so the function returned
(nil, nil) and the caller dereferenced a nil *UnpackedEnvelope.

Fixes the same pattern at one more call site found by auditing every
errors.Wrap/Wrapf(err, ...) call site in the codebase for a guard
condition that doesn't mention err: state.GetCertification reported a
missing certification as success. (A third instance, in
ordering.CFTBroadcaster.Broadcast, is fixed separately on
refactor/cft-broadcast-simplify, alongside an unrelated retry-loop
simplification.)

Adds the fuzzer's crasher input as a permanent regression entry under
testdata/fuzz/FuzzTransactionSetFromEnvelopeBytes/, plus two related
seed corpus entries (nil and empty input).

Updates a certification_test.go case that had asserted on the bug's
downstream symptom (a later, unrelated "failed getting channel" error)
rather than the actual missing-certification error.

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

2 of 2 new or added lines in 2 files covered. (100.0%)

7 existing lines in 4 files now uncovered.

27089 of 31663 relevant lines covered (85.55%)

2726.48 hits per line