coreui / coreui-pro / 34542591849

95%

main: 94%

push

github

fix(Popup): let an open panel own Escape so an enclosing dialog stays open (#1238)

Escape inside a picker or combobox menu that sits in a <dialog> closed
both: the panel's listener on document only called hide(), so the same
press bubbled to the dialog and, unprevented, made the browser fire the
dialog's native `cancel`.

Focus already lives in the panel while it is open, the way it does in a
native date control, so the panel now takes the press for itself: Popup
listens on its content and anchor and calls preventDefault() and
stopPropagation() before hiding; Autocomplete, MultiSelect and Combobox
do the same on their field while the menu is shown, and leave a press on
a closed menu alone so it reaches the dialog. Escape no longer reopens
a closed Autocomplete menu, which had swallowed the second press.

5711 of 6395 branches covered (89.3%)

Branch coverage included in aggregate %.

19 of 19 new or added lines in 4 files covered. (100.0%)

10909 of 11347 relevant lines covered (96.14%)

441.68 hits per line