coreui / coreui-pro / 34541519767

95%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

feat(pickers): one event contract for show, hide, dateChange and reset (#1237)

Three contracts the popup-based components did not share with Modal and
Dialog, or with each other:

- `show` and `hide` could not be cancelled. Popup gains `onBeforeShow` /
  `onBeforeHide` hooks that veto the change when they return false; the
  four pickers emit `show`/`hide` from them, and ComboboxBase checks
  `defaultPrevented` before touching the DOM. `hide()` on a panel that
  is not shown no longer emits anything. Popup.dispose() bypasses the
  veto — the owner is going away.
- `dateChange` / `startDateChange` / `endDateChange` carried two shapes:
  `{ date: Date }` from the field, `{ date: formatted, dateObject }` from
  the calendar, and the calendar path announced the clicked day even when
  the field refused it. Both paths now report `{ date, formattedDate }`
  read from the field after the update — `date` the validated Date or
  null, `formattedDate` that value in the shape of `selectionType`.
- SectionInput.reset() went back to `_config.date`, which update()
  overwrites, so create A → update B → reset gave B. The field now keeps
  the date it was created with, reset() emits `dateChange` when the value
  moves, and a native form reset resets the field as well.

Coverage Stats

5703 of 6388 branches covered (89.28%)

Branch coverage included in aggregate %.

42 of 42 new or added lines in 7 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

10891 of 11329 relevant lines covered (96.13%)

439.92 hits per line