ruby-grape / grape / 34523062380

99%

master: 99%

Pull #2928

github

Settle the attributes iterator's per-scope state once per pass

For every element of an array scope, and for every validator on it,
`AttributesIterator#do_each` re-derived things that depend only on the
scope and the request: whether the scope iterates elements, whether its
params are an Array, which scope an element's index is recorded
against, and the request's `ParamScopeTracker`, a fiber-storage read.

They are now settled once per `#each` and handed down, and the
top-level call no longer allocates its empty `parent_indices`. An
element-iterating scope whose params are not an Array returns before
iterating, since it yielded and recorded nothing anyway. On a
ten-element array, one validator's iteration overhead went from 5.46 to
4.64 µs.

The branch where a lateral scope, such as a `with` group inside an
array, records each element's index against its nearest array ancestor
had no spec: removing it passed the suite while naming the wrong element
in errors. It now has one, which passes before and after this change.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1308 of 1352 branches covered (96.75%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

4040 of 4040 relevant lines covered (100.0%)

27271.38 hits per line