ruby-grape / grape / 34519653519

99%

master: 99%

Pull #2925

github

Skip the qualifying-params lookup for scopes other than `given`

A nested scope resolves its params through
`@parent.qualifying_params.presence`, which reads the request's tracker
out of fiber storage and looks the parent up in its identity Hash. That
runs twice per validator on a nested scope, once in `should_validate?`
and once in the attributes iterator, on every request.

Only `#meets_dependency?` ever stores qualifying params, and it returns
before doing so unless the scope has a dependency, i.e. is a `given`.
Every other scope therefore always answered empty, and now does so
without the lookups: about 190 ns per resolution, and a nested validator
went from 1.77 to 1.39 µs.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1308 of 1352 branches covered (96.75%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

4040 of 4040 relevant lines covered (100.0%)

27148.54 hits per line