datatug / datatug-core / 34380550779

100%

push

github

feat(apicontract): schema authority for the Task 12 normative transport (#312)

New pkg/apicontract: Go types mirroring every shared JSON type and envelope
in spec/features/core-investigation-loop/api-contract.md (hub datatug/datatug,
the normative transport appendix), with the exact json:"..." field names -
Scope, SourceRef, TypedValue, PhysicalRef, Fact, Limitation, Binding, Result
(+ Provenance, Recordset, Column), Candidate (+ CandidateTarget, ChainStep,
Ambiguous), ExecutionRequest (+ BindingOriginEntry), AgentInfo, the three
response envelopes, and ErrorEnvelope with the closed ErrorCode set mapped
to exact HTTP statuses. Every type has a Validate() enforcing the appendix's
own stated rules.

DecodeStrict (decode.go) rejects unknown fields (encoding/json's
DisallowUnknownFields), duplicate JSON keys at any nesting level
(encoding/json otherwise silently keeps only the last occurrence), trailing
data, and explicitly named forbidden fields (client-supplied principal/role).
TypedValue's own UnmarshalJSON runs the same duplicate-key check
independently, since it is invoked by encoding/json's machinery whenever
embedded in a larger structure, bypassing any caller's own DecodeStrict call.

pkg/apicontract/fixtures: 40 frozen JSON fixtures (Manifest() returns
name+SHA-256 for each, so server/client can pin an exact set and detect
drift) covering every envelope, every one of the 13 closed error codes,
TypedValue's null/false/zero/large-integer edge cases, empty-array cases,
ambiguous/missing-input Candidate states, a generic-policy/no-visible-names
Limitation (the "omitted unauthorized metadata" case), and a live/snapshot
Result pair. Every fixture round-trips through its Go type byte-for-byte
(json.MarshalIndent, 2-space) and passes its own Validate().

100% statement coverage on both pkg/apicontract and pkg/apicontract/fixtures.


Claude-Session: https://claude.ai/code/session_01TBRZM85u8kayPG3UVHydaz

Co-authored-by: Alexander Trakhimenok <trakhimeno... (continued)

563 of 0 new or added lines in 0 files covered. (NaN%)

4645 of 5049 relevant lines covered (92.0%)

0.92 hits per line