datatug / datatug-core / 34379361439

100%

push

github

feat(model): board SQL widgets reference a query instead of embedding SQL (#311)

Founder ruling 2026-09-09: put to the founder as option 1 of three ("Widget
references a library query. SQLWidgetSettings becomes a query reference plus
parameter bindings; the target comes from the referenced QueryDef.Targets,
and environment stays a view-time choice."). Founder answered verbatim:
"I'm Ok with the suggested option 1". The DIRECTION is founder-ruled; the
exact field shape (QueryID + WidgetParameterBindings) is the coding agent's
design, not the founder's, and is marked as such in code comments.

This REMOVES the exported field SQLWidgetSettings.Query and replaces it with
QueryID plus a Parameters binding list. Below 1.0.0 (this module has no
tagged 1.x release) a minor version bump is the honest bump for a removed
exported field on a breaking-shape struct; do not read this as needing a
major-version marker.

SQLWidgetSettings.Validate requires queryId and delegates to the new
WidgetParameterBindings/WidgetParameterBinding validators, which reject a
binding missing its id, a binding with both Value and BoardParameterID set,
and duplicate binding ids for the same parameter. Neither Value nor
BoardParameterID being set is valid and means "use the referenced query
parameter's own default" (ParameterDef.DefaultValue).

Updated the 8 existing test-literal sites in boards_test.go that constructed
SQLWidgetSettings{Query: ...} and added table-driven validation tests plus a
JSON round-trip test for the new shape.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

22 of 0 new or added lines in 0 files covered. (NaN%)

4082 of 4486 relevant lines covered (90.99%)

0.91 hits per line