datatug / datatug-core / 34389064767

100%

push

github

feat(apicontract): request envelopes for applicable, related and related rows (#313)

datatug-core v0.26.0 shipped ApplicableResponse, RelatedResponse and
ExecutionRequest but not a request envelope for the other three POST
endpoints the appendix defines (spec/features/core-investigation-loop/
api-contract.md "Endpoint table", hub datatug/datatug) - a gap lane S78
found while adopting this package in datatug-cli's PR #213. Adds
ApplicableRequest (queries/applicable), RelatedRequest (semantic/related)
and RelatedRowsRequest (semantic/related/rows), each flattening its Scope
fields into its own top level exactly like ExecutionRequest already does -
never nested under a "scope" key, confirmed against the live server by
lane S77.

Validate() on each enforces the same strictness ExecutionRequest already
does: required project/environment/securityContextId, embedded Fact/
TypedValue validity, and a bounded optional limit - 1-50 for
RelatedRequest (reusing responses.go's relatedMaxItems, since related
discovery never returns more than 50 targets), 1-500 for
RelatedRowsRequest (reusing execution_request.go's executionMaxLimit,
since it returns the same Result shape exec/run_query does).
RelatedRowsRequest additionally requires a nonempty opaque lookupId.

Golden fixtures for all three are registered in
fixtures_roundtrip_test.go's decode/validate/re-encode-byte-for-byte
suite; Manifest() auto-discovers them via the package's existing
embed glob. Field names were cross-checked against datatug-cli's own
local composition on PR #213's branch (refactor/phase1-apicontract-swap)
and agree exactly.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

51 of 0 new or added lines in 0 files covered. (NaN%)

4696 of 5100 relevant lines covered (92.08%)

0.92 hits per line