datatug / datatug-core / 34352258037

100%

Build Type

push

github

Committed by web-flow

Commit Message

fix(filestore): load and save Project.Queries so QueryDefTarget credential checks apply (#309)

LoadProject never populated Project.Queries (SaveProject never saved it
either), so Project.Validate() could never reach QueryDefTarget.Validate()'s
committed-credential check (v0.17.0) - datatug validate silently passed a
query with a plaintext password because there was nothing to validate.

- fsQueriesStore gains loadQueriesTree/saveQueriesTree: a recursive folder
  walk (LoadQueries only scans one folder at a time) that LoadProject and
  SaveProject now wire into their parallel.Run fan-out, same dual-layout
  discipline as entities/boards/dbmodels. A folder holding only unrelated
  files (e.g. the demo project's legacy *.sql.json queries, which predate
  the "<id>.query.json" suffix convention) is naturally excluded.
- LoadQuery/LoadQueries never read a query's text body back from its
  "<id>.query.<type>" sidecar file (the saver always strips Text before
  writing the JSON) - fixed via readQueryTextSidecar, a separate,
  previously-undiscovered gap this stream also closes.
- Extended the demo-project-1 fixture test: all 5 real demo queries (DTQL
  customer-invoices, SQL customer-purchases-by-genre/invoice-lines, HTTP
  country-facts/currency-rate) now load with their text; injecting a
  user:pass@ URL into a copied query's Targets now fails Project.Validate().
  Project.Validate() on the real demo project is now asserted to fully
  succeed - lane S42 (datatug-demo-projects PR #11/#12) fixed the sqlite3
  host issue this test previously had to assert around.

Not fixed (out of scope): the demo project's legacy albums/artists/tracks
*.sql.json queries (pre-date the current naming convention, confirmed
excluded rather than silently misread); SaveQuery (singular) ignoring
QueryDefWithFolderPath.FolderPath (pre-existing, unrelated to the load path).


Claude-Session: https://claude.ai/code/session_01TBRZM85u8kayPG3UVHydaz

Co-authored-by: Alexander Trakhime... (continued)

Coverage Stats

78 of 90 new or added lines in 4 files covered. (86.67%)

25 existing lines in 3 files now uncovered.

4058 of 4462 relevant lines covered (90.95%)

0.91 hits per line