datatug / datatug-core / 34349580300

100%

Build Type

push

github

Committed by web-flow

Commit Message

fix(filestore): load environments the way the demo project ships them, fix sqlite3 ServerRef.Validate (#307) (#308)

- ServerRef.Validate()'s "sqlite3" case fell through into the generic
  host-required check instead of returning, so no sqlite3 ServerRef could
  ever validate (present v0.17.0..v0.21.0; the old vendored copy had the
  return). Fixes #307.
- fsEnvironmentsStore now loads and saves both filenames within a per-
  environment directory: the legacy "environment-summary.json" and the
  demo's own "<id>.env.json" (datatug-demo-projects/demo-project-1/
  environments/local/local.env.json). Demo's filename wins when both exist
  and agree; disagreement is a clear error; a save keeps the filename an
  environment was loaded from; a brand-new environment defaults to the
  demo's filename. DeleteEnvironment now removes the whole per-environment
  directory (environments are always directory-based; the old
  generic-helper path deleted the wrong file entirely).
- fsEnvDbCatalogStore (LoadEnvDbCatalog/LoadEnvDbCatalogs) now share one
  path - environments/<envID>/catalogs/ - and both accept flat
  "<id>.db.json" and nested "<id>/<id>.db.json" (matching
  environments/local/catalogs/chinook-local/chinook-local.db.json).
  LoadEnvDbCatalog previously used a different, servers/<serverID>-
  qualified path that could never agree with LoadEnvDbCatalogs (the
  existing test's own comments flagged this before this fix).
- Removed the now-dead loadEnvFile in loader_internals.go (its only caller,
  LoadEnvironmentSummary, is rewritten).


Claude-Session: https://claude.ai/code/session_01TBRZM85u8kayPG3UVHydaz

Co-authored-by: Alexander Trakhimenok <trakhimenok@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Coverage Stats

185 of 205 new or added lines in 3 files covered. (90.24%)

48 existing lines in 4 files now uncovered.

3974 of 4376 relevant lines covered (90.81%)

0.91 hits per line