archetech / archon / 34165202995

87%

push

github

feat(cli): Keep the wallet where the CLI can find it from any directory (#1072)

* feat(cli): Keep the wallet where the CLI can find it from any directory

`npm install -g` gives a binary that works anywhere; `./wallet.json` gives an
identity that works in one directory. Create one in ~/newcomer, come back
tomorrow from ~, and the answer is "wallet not found" with an invitation to
create another -- leaving the first on disk where nobody is looking. The
passphrase that unlocks it is already kept under the home directory, so the
wallet belongs there too.

A new wallet now goes to ~/.archon/wallet.json. One already sitting in the
working directory still wins, so a setup built that way goes on working
untouched, and ARCHON_WALLET_PATH beats both -- including when it points at
nothing, because an explicit path is an instruction and the error should name
what was asked for.

The message when none is found no longer offers create-wallet as the only
route: it says a wallet made elsewhere is still there and how to point at it,
and names the home location when that is not where it looked.

Both CLIs, the MCP server and the two lightning scripts resolve it the same
way, through one exported module -- an agent and its operator seeing different
identities would be the same bug wearing a different hat. loadConfig gained a
seam for it, because the default was otherwise read off whichever machine ran
the tests.

Closes #980

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

* fix(keymaster): Let the SQLite wallet open an absolute path, and make its folder

Review found that ARCHON_WALLET_TYPE=sqlite could not open the new default.
WalletSQLite builds `${dataFolder}/${walletFileName}` unconditionally, so an
absolute path became `data//home/you/.archon/wallet.json` -- a location nobody
asked for. That was already true of any absolute ARCHON_WALLET_PATH; making
the default absolute turned a lat... (continued)

3968 of 4556 branches covered (87.09%)

Branch coverage included in aggregate %.

18 of 18 new or added lines in 3 files covered. (100.0%)

8611 of 9037 relevant lines covered (95.29%)

718.35 hits per line