archetech / archon / 34174959598

87%

push

github

fix(keymaster): Make a wallet path mean a path under both backends (#1074)

* fix(keymaster): Make a wallet path mean a path under both backends

WalletSQLite is constructed with a filename and a folder and joins them.
Every caller resolving ARCHON_WALLET_PATH has a path, and three of the
four passed it whole as the filename, so a relative path was hung under
the store's own data folder: ./wallet.json was kept at data/wallet.json,
while the same path under JSON meant the file it named. That conflation
has already produced an absolute path opening data//home/you/..., a
SQLITE_CANTOPEN on a folder nothing created, and a database written
under a .json name.

openWalletStore() splits the path and constructs the backend, so no
caller decides what a path handed to a store means. The CLI, both
lightning scripts and the MCP runtime use it, and storedAt() — which
existed only so a caller could ask where SQLite would have put a path —
is gone.

SQLite wallets written before this are under data/. Resolution looks
there when nothing is configured, so those keep opening untouched. When
ARCHON_WALLET_PATH names a relative path and a wallet is readable at the
older location, the error names that file instead of offering to create
a second identity on top of it.

Closes #1073

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

* docs(python-cli): State what the CLI reads, not what it cannot open

The module docstring advertised a wallet.db default for a CLI that
builds a JsonWalletStore for every command, and called ARCHON_PASSPHRASE
required without naming the file the CLI reads instead or the prompt it
falls back to.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

* fix(keymaster): Refuse to provision on top of a stranded wallet

The migration check lived in the "no wallet" message, which is reached
only by comm... (continued)

3978 of 4566 branches covered (87.12%)

Branch coverage included in aggregate %.

20 of 20 new or added lines in 4 files covered. (100.0%)

8625 of 9051 relevant lines covered (95.29%)

717.32 hits per line