archetech / archon / 34153170472

87%

push

github

feat(cli): Ask for the wallet passphrase instead of teaching people to export it (#1071)

* feat(cli): Ask for the wallet passphrase instead of teaching people to export it

The quickstart's first instruction was `export ARCHON_PASSPHRASE=...`, and the
CLI had no other way in. That is the key encrypting a wallet which, four
commands later on the same page, holds Lightning funds -- put into shell
history, /proc/<pid>/environ, every child the shell spawns afterwards, and any
CI log. Worse, it was taught: the first thing a new user reads demonstrated it
as the intended pattern.

Both CLIs now resolve it in order: ARCHON_PASSPHRASE (or its older name) for
automation, then ARCHON_PASSPHRASE_FILE, then a prompt with hidden input when
there is a terminal to ask on. A file that is configured and unreadable raises
rather than falling through to the prompt -- an explicit path that is wrong is
an error, not an invitation to type something else, and silently asking would
let a typo mint a different wallet. Nothing is asked when stdin is not a
terminal, which would hang whatever opened the pipe.

The prompt writes its query once and swallows every later redraw, because
readline repaints the whole line per keystroke and would otherwise echo the
secret back. Checked under a pty: with input arriving after the prompt, the
only output is the prompt.

The quickstart leads with the interactive path and mentions the file for
scripts. Both package READMEs follow.

Closes #977

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

* feat(cli): Offer the prompted passphrase a home, and read it back

Prompting alone traded one exported variable for typing the passphrase on
every command, which is what exporting it was buying. The prompt was the only
new way in, so a session of twenty commands asked twenty times.

Both CLIs now read ~/.archon/passphrase when nothing else supplies one, and
offer to write i... (continued)

3952 of 4540 branches covered (87.05%)

Branch coverage included in aggregate %.

19 of 19 new or added lines in 1 file covered. (100.0%)

8594 of 9020 relevant lines covered (95.28%)

719.64 hits per line