archetech / archon / 34146450970

87%

push

github

feat(config): Move the wallet passphrase to ARCHON_PASSPHRASE everywhere (#1070)

* feat(config): Move the wallet passphrase to ARCHON_PASSPHRASE everywhere

The same secret was read from two names depending on which surface you used:
the services took ARCHON_ENCRYPTED_PASSPHRASE, while both CLIs, the lightning
scripts and the MCP server took ARCHON_PASSPHRASE. sample.env set only the
first, so anyone who brought a node up from it and then ran the CLI against
the same data met a required variable they had never seen, holding a value
they already had under another name.

ARCHON_PASSPHRASE is the name to keep -- the other is not an encrypted
passphrase, it is the passphrase used for encryption, and it is the one every
directly-run tool already expects. Every reader now prefers it and falls back
to the old name, which keeps existing deployments working untouched. The
startup check says which name supersedes which, once, and starts anyway.

Compose demands ARCHON_PASSPHRASE and treats ARCHON_ENCRYPTED_PASSPHRASE as
optional, which is the swap that makes the new name reachable at all: a
setting the code reads is not a setting an operator can set unless a compose
file passes it in. Both samples and both env tables lead with the new name and
record the old one as still read.

The MCP smoke test asserted that a missing passphrase is refused, but the
server calls dotenv.config() from the repo root, so on a machine with a .env
holding the old name the fallback now satisfies it. Pinned both names empty in
the spawn environment, since dotenv leaves an already-set variable alone.

Closes #1020

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

* docs(keymaster): Finish the rename in the surfaces the sweep missed

Three from review, and my own grep found two more.

The Swagger description on POST /login still named the old variable, so the
generated docs/keymaster-api.json did too; both no... (continued)

3933 of 4521 branches covered (86.99%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

8575 of 9001 relevant lines covered (95.27%)

721.17 hits per line