accordproject / concerto / 34145458079

98%

push

github

fix(concerto-core): reject non-array JSON for array fields instead of corrupting it (#1313)

visitField and visitRelationshipDeclaration cast the popped value to an
array and iterated it by length. A string iterated as characters, so a
String[] field fed "hello" deserialized as ["h","e","l","l","o"], and a
number or object had length undefined so the loop was skipped and the value
silently became []. Every scalar mismatch on the same path throws
ValidationException; arrays alone corrupted silently.

Both array paths now guard with Array.isArray and throw a
ValidationException using the existing message and path style.

Tests: string for String[], number for String[], and a string URI for a
relationship array. With only the source reverted the three fail, one of
them proving the character iteration reached Relationship.fromURI per
character (Error: Missing id).

Signed-off-by: rajanpanth <rajan.pantha@samriddhicollege.edu.np>

2224 of 2326 branches covered (95.61%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

4095 of 4137 relevant lines covered (98.98%)

127865.84 hits per line