accordproject / concerto / 34147908513

98%

push

github

fix(concerto-core): reset lastIndex before testing a stateful validator regex (#1310)

* fix(concerto-core): reset lastIndex before testing a stateful validator regex

A regex with the g or y flag is stateful: test() advances lastIndex, so the
same value alternates between matching and failing on consecutive calls. The
CTO grammar parses RegularExpressionFlags, so a model like

    o String code regex=/^[A-Z]{3}$/g

validated every other instance and rejected the ones in between, both in
StringValidator.validate and in Factory.newResource's identifier check.

StringValidator gains a matchesRegex(value) method that resets lastIndex
before testing, and both call sites use it.

Four regression tests added: repeated validation and repeated rejection with
a g flag, repeated validation with a y flag, and three consecutive
newResource calls with a g-flagged identifier regex.

Signed-off-by: rajanpanth <rajan.pantha@samriddhicollege.edu.np>

* fix(concerto-core): also reset lastIndex after testing, so getRegex stays clean

matchesRegex reset lastIndex before the test but left it dirty afterwards,
so a caller of the public getRegex() still received a poisoned object.
Reset in a finally block and assert it in a test.

Signed-off-by: rajanpanth <rajan.pantha@samriddhicollege.edu.np>

---------

Signed-off-by: rajanpanth <rajan.pantha@samriddhicollege.edu.np>

2225 of 2328 branches covered (95.58%)

Branch coverage included in aggregate %.

7 of 8 new or added lines in 2 files covered. (87.5%)

4100 of 4143 relevant lines covered (98.96%)

127815.88 hits per line