hyperledger / fabric-x-committer / 34109194610

91%

Build Type

push

github

Committed by web-flow

Commit Message

[vc] Report queue sizes on scrape (#783)

#### Type of change

- Bug fix
- Improvement (improvement to code, performance, etc)

#### Description

- Replace the validator-committer's ticker-based queue monitor with
gauges evaluated on scrape, and
  delete the sampler goroutine.
- Report each of them with `Provider.NewChannelLenGauge`.
- Gather the service's pipeline channels into a `queues` struct built
before the metrics that
  observe them.
- Add `vcservice_batcher_input_queue_size` for `receivedTxBatch`, the
first queue the service fills
from the coordinator's stream, so coordinator-side over-drive shows up
where it starts rather
  than one stage later.

#### Additional details (Optional)

No metric is renamed and no buffer size changes. The four converted
gauges are now exact at scrape
time rather than up to 250ms stale, so brief spikes the sampler used to
miss will start showing.

#### Related issues

- resolves #770
- related to #730

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

29 of 29 new or added lines in 2 files covered. (100.0%)

14 existing lines in 5 files now uncovered.

9302 of 10285 relevant lines covered (90.44%)

11499.11 hits per line