hyperledger / fabric-x-committer / 34111837228

91%

Build Type

push

github

Committed by web-flow

Commit Message

[coordinator] Report the dependency graph queue sizes on scrape (#810)

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

- Replace the dependency graph manager's ticker-based queue monitor with
gauges read on scrape, and
  delete the sampler goroutine.
- Gather the two input queues into a receive-only `managerQueues` struct
in `manager.go`, built
  before the metrics that observe them.
- Rename `gdgWaitingTxQueueSize` and `dependentTransactionsQueueSize` to
`gdgWaitingTxCount` and
`dependentTxCount`, since neither is a queue: both count transactions
held in the graph's maps and
  stay maintained incrementally.
- Rename the exported
`coordinator_dependency_graph_dependent_transactions_queue_size` to
`coordinator_dependency_graph_dependent_transactions`, for the same
reason.
- Reword `coordinator_global_dependency_graph_size`'s help to lead with
what it counts.
- Remove the `queue-monitor-sampling-time` config key, whose only reader
was the sampler.

#### Additional details (Optional)

Deployed YAML that still sets `queue-monitor-sampling-time` keeps
loading, as `v.Unmarshal` ignores
unknown keys.

Dashboard-breaking:
`coordinator_dependency_graph_dependent_transactions_queue_size` becomes
`coordinator_dependency_graph_dependent_transactions`.
`coordinator_global_dependency_graph_size`
keeps its name, as it never claimed to be a queue.

One of the per-service PRs split out of #736.

#### Related issues

- resolves #771
- related to #730

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

29 of 29 new or added lines in 5 files covered. (100.0%)

14 existing lines in 6 files now uncovered.

9286 of 10276 relevant lines covered (90.37%)

10579.72 hits per line