hyperledger / fabric-x-committer / 34108899078

91%

Build Type

push

github

Committed by web-flow

Commit Message

[sidecar] Separate mapping's scaffolding from its result (#800)

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

- `blockMapper` now holds the relay's in-flight TX ID map and embeds the
`blockMappingResult` it is filling. The eight methods that build a block
moved onto
  it; `blockWithStatus`, whose methods read a built block, is untouched.
- `mapBlock` creates a mapper, uses it, and returns only
`mapper.blockMappingResult`,
so the map reference stops being reachable at that point. Receiver
renames aside,
  the method bodies are unchanged.
- Drops the `//nolint:gosec` on the `mapMessage` call: gosec does not
flag that
conversion, so touching the line made `nolintlint` fail on the unused
directive.

#### Additional details (Optional)

The issue also names the three per-block slabs and the collected TX IDs.
Those do not
exist yet — they arrive with #788 and #772 — so this change moves the
one piece of
scaffolding `blockMappingResult` carries today. Once those land, their
state goes onto
this mapper rather than onto the result.

#### Related issues

- resolves #789

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

42 of 47 new or added lines in 1 file covered. (89.36%)

15 existing lines in 8 files now uncovered.

9306 of 10296 relevant lines covered (90.38%)

12299.33 hits per line