archetech / archon / 34038971416

87%

push

github

fix(services): Make a failed startup fatal instead of a logged line (#1057)

* fix(services): Make a failed startup fatal instead of a logged line

Every long-running service installed uncaughtException and unhandledRejection
handlers that logged and returned. All four do their real startup after
binding a port -- from inside the listen callback, or from a main() nobody
awaits -- so a throw there was a rejection those handlers swallowed. What
remained was a process that answered /version and /metrics, failed every real
route, and never exited. Keymaster and Herald each grew their own
try/process.exit wrapper for it (#1048, #1050); Gatekeeper installed its
handlers after main() was already running, and the Hyperswarm mediator binds
its metrics port partway through startup.

Give them one guard that is fatal until the service says it is up, and
tolerant afterwards so a bad request still cannot take a running service
down. The two hand-rolled wrappers go with it: Herald's covered only part of
its bootstrap, leaving initServiceIdentity and ensureIpnsKeyExists swallowed.

Herald's routes module no longer installs process handlers either -- every
test that built the routes was installing them on its worker.

Closes #1053

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

* fix(common): Map the new subpath for legacy type resolution, and parse the guard test

typesVersions carries every other @didcid/common subpath, and a consumer on
TypeScript's `node` resolution reads the published package through it. Without
an entry, `@didcid/common/process-guards` resolves to TS2307 there.

The entry-point assertions counted occurrences of startupComplete in the file
text. Three of the four services name it in their comments as well, so
deleting the call itself left keymaster at three occurrences and herald at
two, and the test stayed green for the regression it exists to catch. Parse
the file ... (continued)

3928 of 4518 branches covered (86.94%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 1 file covered. (100.0%)

8574 of 9000 relevant lines covered (95.27%)

721.21 hits per line